fix: Refactor pinning authorization logic to use user_tag table #1654

ghost · 2022-03-17T15:35:28Z

see feat: refactor pinning authorization logic to use user_tag table #1389 Refactor pinning authorization logic away from global CloudFlare worker variable to user_tag table #1381
Adding a missing comma.
Filtering tags on deleted_at is null.
Removing some PSA_ALLOW references.

cloudflare-workers-and-pages · 2022-03-17T15:38:55Z

Deploying with Cloudflare Pages

Latest commit:	`52f610e`
Status:	✅ Deploy successful!
Preview URL:	https://5accb452.nft-storage-1at.pages.dev

View logs

* see #1389 #1381 * Adding a missing comma. * Filtering tags on deleted_at is null. * Removing some PSA_ALLOW references.

the-simian · 2022-03-17T20:31:33Z

packages/api/src/utils/db-client.js

@@ -83,13 +83,15 @@ export class DBClient {
    magic_link_id,
    github_id,
    did,
-    keys:auth_key_user_id_fkey(user_id,id,name,secret)
+    keys:auth_key_user_id_fkey(user_id,id,name,secret),


some kind of editor or linter support for this would be nice. No idea if that exists, you you need an eagle eye to catch this

the-simian

Looks good, congrats on locating that

ghost force-pushed the bugfix/trigramdev9/attempting-build-fix branch 6 times, most recently from cf3d65e to f3f8b22 Compare March 17, 2022 16:21

fix: Refactor pinning authorization logic to use user_tag table

52f610e

* see #1389 #1381 * Adding a missing comma. * Filtering tags on deleted_at is null. * Removing some PSA_ALLOW references.

ghost force-pushed the bugfix/trigramdev9/attempting-build-fix branch from f3f8b22 to 52f610e Compare March 17, 2022 20:10

ghost changed the title ~~Attempting to fix build after #1389 was merged without it being updated to the latest from main~~ fix: Refactor pinning authorization logic to use user_tag table Mar 17, 2022

e-schneid self-requested a review March 17, 2022 20:30

e-schneid approved these changes Mar 17, 2022

View reviewed changes

the-simian reviewed Mar 17, 2022

View reviewed changes

the-simian approved these changes Mar 17, 2022

View reviewed changes

the-simian merged commit 043049e into main Mar 17, 2022

the-simian deleted the bugfix/trigramdev9/attempting-build-fix branch March 17, 2022 20:40

github-actions bot mentioned this pull request Mar 17, 2022

chore(main): release api 2.19.0 #1631

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Refactor pinning authorization logic to use user_tag table #1654

fix: Refactor pinning authorization logic to use user_tag table #1654

ghost commented Mar 17, 2022 •

edited by ghost

Loading

cloudflare-workers-and-pages bot commented Mar 17, 2022 •

edited

Loading

the-simian Mar 17, 2022

the-simian left a comment

fix: Refactor pinning authorization logic to use user_tag table #1654

fix: Refactor pinning authorization logic to use user_tag table #1654

Conversation

ghost commented Mar 17, 2022 • edited by ghost Loading

cloudflare-workers-and-pages bot commented Mar 17, 2022 • edited Loading

Deploying with Cloudflare Pages

the-simian Mar 17, 2022

Choose a reason for hiding this comment

the-simian left a comment

Choose a reason for hiding this comment

ghost commented Mar 17, 2022 •

edited by ghost

Loading

cloudflare-workers-and-pages bot commented Mar 17, 2022 •

edited

Loading