Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Update nft stats query #1877

Closed
dashcraft opened this issue Apr 30, 2022 · 0 comments · Fixed by #1906
Closed

Chore: Update nft stats query #1877

dashcraft opened this issue Apr 30, 2022 · 0 comments · Fixed by #1906
Assignees
@dashcraft
Labels
kind/bug A bug in existing code (including security flaws) pi/dotstorage-site-improvements Improvements to web3 and nft websites stack/website

Comments

@dashcraft
Copy link
Contributor

As @ribasushi pointed out, there may be more dimensions added in the future, so hard coding to 2 is not ideal, need to use tuple/array queries to specify dimensions to query against.

72480d6#r72547350
@dashcraft dashcraft added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Apr 30, 2022
@dashcraft dashcraft self-assigned this Apr 30, 2022
@JeffLowe JeffLowe added pi/website-nft-0 stack/website and removed need/triage Needs initial labeling and prioritization labels May 3, 2022
@johnathonroach johnathonroach mentioned this issue May 11, 2022
Merged
@JeffLowe JeffLowe added potential/websites-pi work to package into upcoming websites initiative pi/dotstorage-site-improvements Improvements to web3 and nft websites and removed pi/website-nft-0 potential/websites-pi work to package into upcoming websites initiative labels May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dashcraft dashcraft

Labels
kind/bug A bug in existing code (including security flaws) pi/dotstorage-site-improvements Improvements to web3 and nft websites stack/website
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: optimize metrics query nftstorage/nft.storage
2 participants
@JeffLowe @dashcraft