feat: seo optimization #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…browser with no API token
Deploying with
|
| Latest commit: |
cbca048
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1856014b.nft-storage-1at.pages.dev |
|
@Codigo-Fuentes is this ready for review (it says "in progress" in the description)? |
|
Yes, sorry I forgot to remove that. |
dashcraft
suggested changes
Nov 19, 2021
packages/website/pages/terms.js
Outdated
| @@ -39,9 +40,9 @@ export default function TermsOfService() { | |||
| If you do not agree to all the terms and conditions of this agreement, | |||
| then you may not access the Website or use any services. | |||
| </p> | |||
| <h2 className="chicagoflf"> | |||
There was a problem hiding this comment.
Just a comment, should probably run this page through axe dev tools to make sure the header tag hierarchy is consistent, i figure that's why they're being moved down to h3's but i wanted to make sure i put this in a comment for posterity.
dashcraft
approved these changes
Nov 23, 2021
|
There is a significant amount of change here not relevant to this PR - please can we avoid in the future? Looks like a code formatter tool has been run across a bunch of packages. Next time please submit these changes as a seperate PR 🙏 |
This was referenced Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #437