-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): add overview page for js client & links to generated clients #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusefnapora
requested review from
alanshaw,
hugomrdias,
vasco-santos,
dchoi27 and
dashcraft
February 22, 2022 22:30
Deploying with Cloudflare Pages
|
Does this negate the need for #1256 ? |
JeffLowe
added
the
need/update
manually applied to any needing verbal update during meetings
label
Feb 28, 2022
@JeffLowe I think so, yes. Just closed that one, thanks for reminding me. I'll rebase this and fix conflicts in a sec |
yusefnapora
force-pushed
the
docs/client-cleanup
branch
from
February 28, 2022 19:58
72377b5
to
26aa2a0
Compare
dashcraft
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
JeffLowe
removed
the
need/update
manually applied to any needing verbal update during meetings
label
Mar 1, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the docs in the "Client" section of the nav with a page for the JS client and one for the OpenAPI generated clients. The JS page is an overview of installing the client, constructing an instance, and the various store methods available, plus a mention of
delete
. It should probably also includecheck
and so on, but we can add that in a future PR.