Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add overview page for js client & links to generated clients #1450

Merged
merged 7 commits into from
Mar 1, 2022

Conversation

yusefnapora
Copy link
Contributor

This replaces the docs in the "Client" section of the nav with a page for the JS client and one for the OpenAPI generated clients. The JS page is an overview of installing the client, constructing an instance, and the various store methods available, plus a mention of delete. It should probably also include check and so on, but we can add that in a future PR.

Screen Shot 2022-02-22 at 5 30 08 PM

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 22, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 26aa2a0
Status: ✅  Deploy successful!
Preview URL: https://189d4cc4.nft-storage-1at.pages.dev

View logs

@JeffLowe JeffLowe added the topic/docs Documentation label Feb 27, 2022
@JeffLowe
Copy link
Contributor

Does this negate the need for #1256 ?

@JeffLowe JeffLowe added the need/update manually applied to any needing verbal update during meetings label Feb 28, 2022
@yusefnapora
Copy link
Contributor Author

@JeffLowe I think so, yes. Just closed that one, thanks for reminding me. I'll rebase this and fix conflicts in a sec

Copy link
Contributor

@dashcraft dashcraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@JeffLowe JeffLowe removed the need/update manually applied to any needing verbal update during meetings label Mar 1, 2022
@JeffLowe JeffLowe mentioned this pull request Mar 1, 2022
@yusefnapora yusefnapora merged commit 236fda4 into main Mar 1, 2022
@yusefnapora yusefnapora deleted the docs/client-cleanup branch March 1, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants