Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade wrangler #128

Merged
merged 1 commit into from
Jun 1, 2022
Merged

fix: upgrade wrangler #128

merged 1 commit into from
Jun 1, 2022

Conversation

vasco-santos
Copy link
Contributor

@vasco-santos vasco-santos commented May 31, 2022

This PR upgrades wrangle to its v2 in api, edge-gateway and website packages.

Now Wrangler provides super easy way of deploying to CF Pages and we are using it in the website, allowing us to get rid of the tools package

Some details of the changes for api and edge-gateway:

- 😶 Ignored: "type":
      Most common features now work out of the box with wrangler, including modules, jsx,
  typescript, etc. If you need anything more, use a custom build.
    - Deprecation: "build.upload.format":
      The format is inferred automatically from the code.
    - Deprecation: "build.upload.main":
      Delete the `build.upload.main` and `build.upload.dir` fields.
      Then add the top level `main` field to your configuration file:
      ```
      main = "dist/worker.mjs"
      ```
    - Deprecation: "build.upload.dir":
      Use the top level "main" field or a command-line argument to specify the entry-point for the
  Worker.
    - Unexpected fields found in top-level field: "watch_dir"
    - "env.staging" environment configuration
      - Deprecation: "zone_id":
        This is unnecessary since we can deduce this from routes directly.

TODO:

  • Disable automatic main deploy in CF Pages

Closes #117

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 31, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: aa3ab63
Status: ✅  Deploy successful!
Preview URL: https://cd040f57.nftstorage-link.pages.dev

View logs

@vasco-santos vasco-santos force-pushed the fix/upgrade-wrangler branch 2 times, most recently from 992d088 to fffa86c Compare May 31, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use wrangler 2
1 participant