feat: superhot support for w3s.link read #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
approved these changes
Aug 5, 2022
Comment on lines
+33
to
+34
| !env.GATEWAY_DOMAINS.filter((gwDomain) => urlString.includes(gwDomain)) | ||
| .length |
There was a problem hiding this comment.
Suggested change
| !env.GATEWAY_DOMAINS.filter((gwDomain) => urlString.includes(gwDomain)) | |
| .length | |
| !env.GATEWAY_DOMAINS.includes(new URL(urlString).hostname) |
...for the reason that the user could put w3s.link in the pathname otherwise.
There was a problem hiding this comment.
const a = new URL('http://bafkreidyeivj7adnnac6ljvzj2e3rd5xdw3revw4da7mx2ckrstapoupoq.ipfs.localhost:9081')
a.hostname
'bafkreidyeivj7adnnac6ljvzj2e3rd5xdw3revw4da7mx2ckrstapoupoq.ipfs.localhost'URLs are tricky, we can't go the way suggested here
There was a problem hiding this comment.
Just url.host and .endsWith instead? I think it's better to use the domain if we can!
Deploying with
|
| Latest commit: |
22052e6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://56f2f768.nftstorage-link.pages.dev |
| Branch Preview URL: | https://feat-super-hot-support-w3s-l.nftstorage-link.pages.dev |
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
vasco-santos
force-pushed
the
feat/super-hot-support-w3s.link
branch
from
9afff9c
to
22052e6
Compare
This was referenced Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for superhot reads in w3s.link - we still need to look into moving this API into a common context instead of tied with nftstorage.link (not included in current initiative scope)
w3s.link should be able to read from SuperHot perma-cache and also share same content in R2 regardless of domain used for perma-cache. It currently gets 400 error due to not being a valid domain to get. This PR changes that by allowing reads from either nftstorage.link or w3s.link (array in ENV variable).
Moreover, I took decision here to modify normalized URLs to just be w3s.link all the time (converted from nftstorage.link when those are provided). Main reason for this is our current direction of Web3.storage platform and nft.storage being part of the stack.