Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: website with open api docs #71

Merged
merged 5 commits into from
May 20, 2022
Merged

Conversation

vasco-santos
Copy link
Contributor

@vasco-santos vasco-santos commented Apr 28, 2022

@vasco-santos vasco-santos force-pushed the feat/website-with-open-api-docs branch from e09a311 to 4c55077 Compare April 28, 2022 17:16
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 28, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 56815ff
Status: ✅  Deploy successful!
Preview URL: https://c4faeb0f.nftstorage-link.pages.dev

View logs

@vasco-santos vasco-santos force-pushed the feat/website-with-open-api-docs branch 2 times, most recently from 1420308 to ab9db2a Compare May 1, 2022 14:49
@vasco-santos vasco-santos force-pushed the feat/website-with-open-api-docs branch 4 times, most recently from 37756a1 to 83c86b5 Compare May 17, 2022 14:14
@vasco-santos vasco-santos force-pushed the feat/website-with-open-api-docs branch from 3902b3e to fe722c7 Compare May 19, 2022 12:53
ok:
type: boolean
default: true
value:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK the repsonses do not use the { ok, value }/{ ok, error } pattern.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks, fixed now

packages/website/public/schema.yml Outdated Show resolved Hide resolved
packages/website/public/schema.yml Outdated Show resolved Hide resolved
packages/website/public/schema.yml Outdated Show resolved Hide resolved
packages/website/public/schema.yml Outdated Show resolved Hide resolved
packages/website/public/schema.yml Outdated Show resolved Hide resolved
packages/website/public/schema.yml Outdated Show resolved Hide resolved
packages/website/public/schema.yml Outdated Show resolved Hide resolved
packages/website/public/schema.yml Outdated Show resolved Hide resolved
vasco-santos and others added 2 commits May 20, 2022 14:45
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Copy link

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please fix the typo!

packages/website/public/schema.yml Outdated Show resolved Hide resolved
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
@vasco-santos vasco-santos merged commit 768e157 into main May 20, 2022
@vasco-santos vasco-santos deleted the feat/website-with-open-api-docs branch May 20, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SuperHot OpenAPI docs
2 participants