feat: api metrics #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
feat/api-metrics
branch
from
4c1b44a
to
2c40586
Compare
Deploying with
|
| Latest commit: |
81103d0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://010346e1.nftstorage-link.pages.dev |
vasco-santos
force-pushed
the
feat/api-metrics
branch
from
2c40586
to
d342a55
Compare
vasco-santos
force-pushed
the
feat/api-metrics
branch
2 times, most recently
from
7572044
to
af2b015
Compare
vasco-santos
force-pushed
the
feat/api-metrics
branch
from
af2b015
to
4bc0ac2
Compare
alanshaw
approved these changes
May 20, 2022
packages/api/src/metrics.js
Outdated
| `nftlinkapi_permacache_size_total ${sizeTotal}`, | ||
| `# HELP nftlinkapi_permacache_events_total Total perma cache events.`, | ||
| `# TYPE nftlinkapi_permacache_events_total counter`, | ||
| `nftlinkapi_permacache_events_total ${eventsTotal}`, |
There was a problem hiding this comment.
Split by type?
Suggested change
| `nftlinkapi_permacache_events_total ${eventsTotal}`, | |
| `nftlinkapi_permacache_events_total{type="Put"} ${putEventsTotal}`, | |
| `nftlinkapi_permacache_events_total{type="Delete"} ${deleteEventsTotal}`, |
| `# HELP nftlinkapi_permacache_events_total Total perma cache events.`, | ||
| `# TYPE nftlinkapi_permacache_events_total counter`, | ||
| `nftlinkapi_permacache_events_total ${eventsTotal}`, | ||
| ].join('\n') |
There was a problem hiding this comment.
I used this prom-client library in checkup https://github.com/nftstorage/checkup/blob/main/prom.js - it might make things a bit less error prone here.
There was a problem hiding this comment.
I will do this as follow up.
packages/cron/src/jobs/metrics.js
Outdated
Comment on lines
12
to
16
| const COUNT_USERS = ` | ||
| SELECT COUNT(*) AS total | ||
| FROM nftstorage.user u JOIN nftstorage.user_tag ut | ||
| ON u.id = ut.user_id | ||
| WHERE ut.tag = 'HasSuperHotAccess'::user_tag_type AND ut.value = 'true' | ||
| ` |
There was a problem hiding this comment.
Isn't this just a count of HasSuperHotAccess tags?
Suggested change
| const COUNT_USERS = ` | |
| SELECT COUNT(*) AS total | |
| FROM nftstorage.user u JOIN nftstorage.user_tag ut | |
| ON u.id = ut.user_id | |
| WHERE ut.tag = 'HasSuperHotAccess'::user_tag_type AND ut.value = 'true' | |
| ` | |
| const COUNT_USERS = ` | |
| SELECT COUNT(*) AS total | |
| FROM nftstorage.user_tag | |
| WHERE tag = 'HasSuperHotAccess'::user_tag_type AND value = 'true' | |
| ` |
vasco-santos
force-pushed
the
feat/api-metrics
branch
from
7572f10
to
81103d0
Compare
This was referenced May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds metrics endpoint to the API by:
From previous knowledge doing the queries in the API itself would work in the beginning. But let's not wait for fires, and go straight for cron job
Blocked on #86
Closes #56