-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Health status #188
Comments
@maticko |
@pleshakov Thanks for this.
If you tell me where I can update examples documentation... |
@maticko |
@pleshakov Is this resolved, maybe? Interested in some docs about this.. |
@mkozjak for now, please use the example above. although, note that a few additional command-line arguments are required for running the IC. Please see https://github.com/nginxinc/kubernetes-ingress/blob/master/deployments/deployment/nginx-ingress.yaml#L35 and https://github.com/nginxinc/kubernetes-ingress/blob/master/docs/cli-arguments.md for health checking by Kubernetes, we'll be adding an additional endpoint handled by the IC to use in readiness and liveliness probes, and update the manifests and helm chart accordingly. |
Hi @pleshakov We also turned on the Nginx white-list to only whitelist the IP address initiating from our API gateway. However, the health probe is initiating from traffic manager (DNS). Will this health check URL always be allowed to pass through? |
@zhouchong90 this depends on how you enabled white-listing. Could you possibly provide the details? |
Added in: #1029 |
#90 and #100 add support for health check but I cannot see any instructions on how to use this. After some digging around the code, it looks like I would have to build an image on my own and set some flag to enable that. Is there a way that this could be enabled by annotations?
Without this health endpoint, it's hard to setup zero-downtime deployments since we cannot setup readiness and liveness probes. Is there any other workaround?
The text was updated successfully, but these errors were encountered: