Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodeSelector, nodeAffinity and tolerations support in helm chart #444

Closed
tobysmith opened this issue Nov 15, 2018 · 2 comments · Fixed by #456
Closed

nodeSelector, nodeAffinity and tolerations support in helm chart #444

tobysmith opened this issue Nov 15, 2018 · 2 comments · Fixed by #456
Assignees
Labels
proposal An issue that proposes a feature request

Comments

@tobysmith
Copy link

I'm currently installing through the helm chart and need to add the nodeSelector and tolerations fields to the deployment resource. In the cluster I'm deploying to we use taints on node pools to distinguish between separate teams so it is necessary to add a toleration to the deployment. I also wish to constrain the deployment to it's own node pool so I want to use a nodeSelector/nodeAffinity.

Would it be possible to upgrade the deployment helm chart to support these fields?

@Dean-Coakley Dean-Coakley added the proposal An issue that proposes a feature request label Nov 15, 2018
@Dean-Coakley Dean-Coakley self-assigned this Nov 15, 2018
@Dean-Coakley
Copy link
Contributor

Hi @tobysmith

Thanks for the suggestion.

We will add nodeSelector, affinity and tolerations fields to the helm chart and I'll update you here once it is implemented.

@Dean-Coakley
Copy link
Contributor

Dean-Coakley commented Dec 4, 2018

@tobysmith nodeSelector, tolerations and tolerations are now available in deployments on the latest version of the helm chart. #456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal An issue that proposes a feature request
Projects
None yet
2 participants