Increase keepalive-requests from 100 to 1000, the nginx default

[nickzelei]

The default value for keepalive_requests is 1000 as per the nginx docs here. This was changed in version 1.19.10.
However, the ingress controller still defaults this value to 100.

https://docs.nginx.com/nginx-ingress-controller/configuration/global-configuration/configmap-resource/

The same could be said for the timeout, which nginx defaults to 75s, but the controller is still defaulting to 65s.

I was debugging a GOAWAY issue and all of the info I could find around the web pointed to this value. I was relieved to find that the ingress controller was still setting it to a lower value as when bumped to 1000, my issue went away.

[github-actions]

Hi @nickzelei thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

[j1m-ryan]

Hi @nickzelei . Thanks for pointing this descrepancy out. It's great to hear you've managed to resolve your GOAWAY issue by adjusting the configmap values in the mean time.

We've initiated a discussion for this topic here as there are some things to think about before adding this to NIC. Your insights would be highly valuable to the discussion, so please consider contributing.