Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle custom VS and TS template change in ConfigMaps #6689

Closed
jjngx opened this issue Oct 18, 2024 · 1 comment · Fixed by #6780
Closed

Gracefully handle custom VS and TS template change in ConfigMaps #6689

jjngx opened this issue Oct 18, 2024 · 1 comment · Fixed by #6780
Assignees
@jjngx
Labels
backlog Pull requests/issues that are backlog items enhancement Pull requests for new features/feature enhancements
Milestone
v4.0.0

Comments

@jjngx
Copy link
Contributor

jjngx commented Oct 18, 2024

Is your feature request related to a problem? Please describe.

This is a follow up of this PR focusing on Ingress and Main template lifecycle.

Describe the solution you'd like

  • NIC reverts to using default VS and TS templates without the need for restarting the pod.

  • When users delete their custom VS or/and TS templates defined in a ConfigMap, NIC reverts to using default TC and VS templates.

Describe alternatives you've considered

N/A

Additional context

More info about the context here.
@jjngx jjngx added the proposal An issue that proposes a feature request label Oct 18, 2024
@github-actions GitHub Actions
Copy link

Hi @jjngx thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@jjngx jjngx added enhancement Pull requests for new features/feature enhancements needs triage An issue that needs to be triaged and removed needs triage An issue that needs to be triaged labels Oct 18, 2024
@pdabelf5 pdabelf5 added needs triage An issue that needs to be triaged backlog Pull requests/issues that are backlog items and removed needs triage An issue that needs to be triaged proposal An issue that proposes a feature request labels Oct 21, 2024
@jjngx jjngx self-assigned this Oct 25, 2024
@jjngx jjngx added this to the v4.0.0 milestone Oct 25, 2024
@jjngx jjngx linked a pull request Nov 11, 2024 that will close this issue
Use default VS and TS templates when CfgMap obj is deleted #6780
Merged
6 tasks
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done 🚀 in NGINX Ingress Controller Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjngx jjngx

Labels
backlog Pull requests/issues that are backlog items enhancement Pull requests for new features/feature enhancements
Projects
NGINX Ingress Controller
Archived in project
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

Use default VS and TS templates when CfgMap obj is deleted nginxinc/kubernetes-ingress
2 participants
@jjngx @pdabelf5