Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring tolerations in helm chart #1196

Closed
kate-osborn opened this issue Oct 25, 2023 · 0 comments · Fixed by #1192
Closed

Support configuring tolerations in helm chart #1196

kate-osborn opened this issue Oct 25, 2023 · 0 comments · Fixed by #1192
Assignees
Labels
enhancement New feature or request helm-chart Relates to helm chart
Milestone

Comments

@kate-osborn
Copy link
Contributor

Is your enhancement request related to a problem? Please describe.
There's no way to define tolerations for the NGF Pod in the helm chart.

What would you like to be added:
Add tolerations in the helm chart values.

Why this is needed:
Allows users to configure tolerations for the NGF Pod. Tolerations allow the scheduler to schedule pods with matching taints. This is needed for systems that use taints for scheduling.

One use case is described in PR #1192, where there is a separate node pool for system services that has taints applied. In order for NGF to be scheduled on this node pool, tolerations need to be applied to the Pod.

@kate-osborn kate-osborn added the enhancement New feature or request label Oct 25, 2023
@ja20222 ja20222 added this to the v1.1.0 milestone Oct 26, 2023
@ja20222 ja20222 added the helm-chart Relates to helm chart label Oct 26, 2023
@mpstefan mpstefan moved this from 🆕 New to 👀 In Review in NGINX Gateway Fabric Oct 26, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request helm-chart Relates to helm chart
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants