Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make status updater production ready #691

Closed
2 tasks done
kate-osborn opened this issue May 30, 2023 · 2 comments
Closed
2 tasks done

Make status updater production ready #691

kate-osborn opened this issue May 30, 2023 · 2 comments
Labels
enhancement New feature or request epic Represents an epic. Contains sub-issues refined Requirements are refined and the issue is ready to be implemented.
Milestone

Comments

@kate-osborn
Copy link
Contributor

kate-osborn commented May 30, 2023

The StatusUpdater component, responsible for updating statuses of Gateway API resources has a number of limitations:

(1) It doesn't understand the leader election. Only the leader must report the statuses of the resources. Otherwise, multiple replicas will step on each other when trying to report statuses for the same resources.

(5) It doesn't retry on failures. This means there is a chance that some resources will not have up-to-do statuses.
Statuses are important part of the Gateway API, so we need to ensure that the Gateway always keep the resources
statuses up-to-date.

FIXME in the code -- https://github.com/nginxinc/nginx-gateway-kubernetes/blob/890fddb787ff3560b9b743647a36b649d498ae51/internal/status/updater.go#L67

Acceptance criteria:

Tasks

Preview Give feedback
  1. enhancement refined size/medium
    kate-osborn
  2. enhancement refined size/small
    bjee19
@mpstefan mpstefan added the tech-debt Short-term pain, long-term benefit label Jun 9, 2023
@pleshakov pleshakov removed their assignment Jul 7, 2023
@pleshakov pleshakov removed the tech-debt Short-term pain, long-term benefit label Jul 7, 2023
@pleshakov pleshakov changed the title FIXME: Make status updater production ready Make status updater production ready Jul 7, 2023
@mpstefan mpstefan added enhancement New feature or request epic Represents an epic. Contains sub-issues and removed proposal labels Jul 12, 2023
@mpstefan mpstefan added this to the v1.0.0 milestone Jul 12, 2023
@mpstefan
Copy link
Collaborator

Blocked by #637 - We want to tackle leader election before we tackle fixing the status updater.

@mpstefan mpstefan added the blocked Blocked by other issue label Aug 21, 2023
@mpstefan mpstefan added refined Requirements are refined and the issue is ready to be implemented. and removed blocked Blocked by other issue labels Aug 30, 2023
@ja20222
Copy link

ja20222 commented Oct 10, 2023

This can be closed as discussed on our call today as all items are closed within it
@kate-osborn @mpstefan

@ja20222 ja20222 closed this as completed Oct 10, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request epic Represents an epic. Contains sub-issues refined Requirements are refined and the issue is ready to be implemented.
Projects
Archived in project
Development

No branches or pull requests

4 participants