Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data plane provisioner prototype #629

Closed
wants to merge 2 commits into from

Conversation

pleshakov
Copy link
Contributor

  • Adds a provisioner as a separate component
  • Extends NKG to support a specific Gateway and not update GatewayClass status (because the provisioner updates it)

Note: this is a POC.

@github-actions github-actions bot added the enhancement New feature or request label May 8, 2023
@pleshakov pleshakov requested a review from kate-osborn May 8, 2023 15:00
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like this approach 🚀

"github.com/nginxinc/nginx-kubernetes-gateway/internal/reconciler"
)

type newReconcilerFunc func(cfg reconciler.Config) *reconciler.Implementation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the gateway and provisioner share this code rather than have the provisioner copy it?

Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like this approach 🚀

@pleshakov
Copy link
Contributor Author

Closing this PR. A new PR will be created to add a provisioner (#634 )

@pleshakov pleshakov closed this May 17, 2023
@pleshakov pleshakov deleted the feature/dataplane-provision branch June 6, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants