feat(Entity): Add default selectId function for EntityAdapter (#405)

ngrx · Sep 20, 2017 · 2afb792 · 2afb792
1 parent 193e8b3
commit 2afb792
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/modules/entity/src/create_adapter.ts b/modules/entity/src/create_adapter.ts
@@ -10,12 +10,15 @@ import { createSelectorsFactory } from './state_selectors';
 import { createSortedStateAdapter } from './sorted_state_adapter';
 import { createUnsortedStateAdapter } from './unsorted_state_adapter';
 
-export function createEntityAdapter<T>(options: {
-  selectId: IdSelector<T>;
-  sortComparer?: false | Comparer<T>;
-}): EntityAdapter<T> {
+export function createEntityAdapter<T>(
+  options: {
+    selectId?: IdSelector<T>;
+    sortComparer?: false | Comparer<T>;
+  } = {}
+): EntityAdapter<T> {
   const { selectId, sortComparer }: EntityDefinition<T> = {
     sortComparer: false,
+    selectId: (instance: any) => instance.id,
     ...options,
   };
 

diff --git a/modules/store/src/store_module.ts b/modules/store/src/store_module.ts
@@ -149,12 +149,16 @@ export class StoreModule {
   ): ModuleWithProviders;
   static forFeature<T, V extends Action = Action>(
     featureName: string,
-    reducer: ActionReducer<T, V>| InjectionToken<ActionReducer<T, V>>,
+    reducer: ActionReducer<T, V> | InjectionToken<ActionReducer<T, V>>,
     config?: StoreConfig<T, V>
   ): ModuleWithProviders;
   static forFeature(
     featureName: string,
-    reducers: ActionReducerMap<any, any> | InjectionToken<ActionReducerMap<any, any>> | ActionReducer<any, any> | InjectionToken<ActionReducer<any, any>>,
+    reducers:
+      | ActionReducerMap<any, any>
+      | InjectionToken<ActionReducerMap<any, any>>
+      | ActionReducer<any, any>
+      | InjectionToken<ActionReducer<any, any>>,
     config: StoreConfig<any, any> = {}
   ): ModuleWithProviders {
     return {