HttpInterceptor not triggering with lazy loaded modules

[micobarac]

Custom HttpInterceptor not triggering with lazy loaded modules, when using TranslateModule as stated in docs.

It's a complex project, so I cannot show the example code.

The problem with lazy loaded modules and HttpInterceptor is that HttpClientModule can only be imported once in the project inside app.module.ts. Looking into this library's code, I found that HttpClientModule is imported internally, which, I presume, could cause this problem.

The files to look for these imports are:

projects/translate/src/lib/translate.module.ts
projects/translate/src/lib/translate.pipe.spec.ts
projects/translate/src/lib/title.service.spec.ts
projects/translate/src/lib/translate.service.spec.ts

[DenysVuika]

Yes, makes sense. While TranslateService is provided in the root, the lazy module makes a copy of HttpClientModule and corresponding providers if any.

Thanks for reporting, I will try to fix this issue and move HttpClientModule to the app level.

[micobarac]

As the library requires that HttpClientModule should be imported in app.module.ts, HttpClientModule imports should be removed from all the internal files.

[DenysVuika]

@micobarac the unit tests are fine, those need to import HTTP module into the TestBed. Feel free to check this PR and see if that fixes your issue: #15

[micobarac]

@DenysVuika I have tried the commit you suggested and it still doesn't work.

My HttpInterceptor provided inside app.module.ts still doesn't fire.

I think that you haven't removed HttlClientModule from all files but app.module.ts. Can you please check it again? Thanks.

[DenysVuika]

The 1.2 is not published to NPM yet. I removed the file from module but leaving in unit tests, those have nothing to do with your application.

[micobarac]

I added the latest commit from the git repository, not from NPM.

[DenysVuika]

I may need some example to reproduce the issue. So far the library code has no direct imports of the HttpClientModule if you check the repo.

[micobarac]

Perhaps I haven't imported the latest commit well. How do I do it with Yarn, using your Git commit with fix?

[DenysVuika]

I am publishing 1.2.0 right now, you will be able to check in a while directly from NPM

[micobarac]

Ok, thanks :)

[DenysVuika]

1.2.0 is out: https://www.npmjs.com/package/@ngstack/translate/v/1.2.0

[micobarac]

I have tried the 1.2.0 version from NPM and it works like a charm.

Thanks a lot.