fix: 🐛 make log signature not to support promise or observable #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
log-* methods from
LogDriver
interface can returnObservable
andPromise
. This behavior is not desired since theLumberjackService
cannot determine how to handle different scenarios.Issue Number: N/A
What is the new behavior?
Make log-* just to return void.
Does this PR introduce a breaking change?
Any third party logger returning an observable or a promise from its log-* methods will suffer from this change since such behavior is not longer supported.
Fix: subscribe to Observables or handle Promise inside log-* methods
Other information