Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase test coverage and extract test-util library #22

Merged
merged 6 commits into from
Oct 19, 2020

Conversation

LayZeeDK
Copy link
Member

@LayZeeDK LayZeeDK commented Oct 17, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Test utilities are in tests subfolder of Lumberjack publishable library.

Issue Number: N/A

What is the new behavior?

Test utilities are in the @internal/test-util workspace library.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@LayZeeDK LayZeeDK force-pushed the LayZeeDK/test/increase-test-coverage branch from e8d6020 to b4497e6 Compare October 17, 2020 23:49
@NachoVazquez
Copy link
Contributor

Excellent work! Refactoring the test-utils to its own library cleans the repo for good.

I'll continue the review tomorrow, I want to go deep into what's happening in the new tests and utils.

@LayZeeDK LayZeeDK force-pushed the LayZeeDK/test/increase-test-coverage branch 2 times, most recently from b41b521 to e3f9c7d Compare October 18, 2020 20:07
@NachoVazquez NachoVazquez merged commit 6cb159c into main Oct 19, 2020
@NachoVazquez NachoVazquez deleted the LayZeeDK/test/increase-test-coverage branch October 19, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants