-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add timestamp to log entries #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LayZeeDK
force-pushed
the
LayZeeDK/feat/timestamps
branch
from
October 23, 2020 09:05
fa34d70
to
e281ab4
Compare
Let me know if we should use a different property name for
|
I would go for 7 or 8. We could annotate it to describe how to handle the value but the name should be more meaningful. |
LayZeeDK
force-pushed
the
LayZeeDK/feat/timestamps
branch
2 times, most recently
from
October 24, 2020 23:20
42cf608
to
f840d4a
Compare
Wait for updated CI #34. |
LayZeeDK
force-pushed
the
LayZeeDK/feat/timestamps
branch
from
October 25, 2020 17:34
f840d4a
to
ea943f5
Compare
NachoVazquez
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
LumberjackLog
.Issue Number: N/A
What is the new behavior?
createdAt: number
property is added toLumberjackLog
.LumberjackTimeService
is used to determine the timestamp and its formatter.Does this PR introduce a breaking change?
Log creators are removed,
LumberjackLog#createdAt
is added.Other information