From d725b7ee0e665f787bb616acba990c33a5db0eab Mon Sep 17 00:00:00 2001 From: Paul Smith Date: Mon, 25 Nov 2024 18:21:21 +0000 Subject: [PATCH 1/3] adds devcontainer.json for Codespaces and container use --- .devcontainer/devcontainer.json | 65 +++++++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+) create mode 100644 .devcontainer/devcontainer.json diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json new file mode 100644 index 00000000..b7026974 --- /dev/null +++ b/.devcontainer/devcontainer.json @@ -0,0 +1,65 @@ +{ + "name": "NHS Prototype Kit", + "image": "mcr.microsoft.com/devcontainers/universal:2", + // codespaces seems to have an issue using port 2000 so setting to 2001 for the NHS Prototype Kit + "runArgs": ["--env", "PORT=2001"], + "portsAttributes": { + "3001": { + "label": "Running prototype", + // -------------------------------- + // onAutoForward possible options + // -------------------------------- + // you can change the value to one of the following possible options: + // 'notify' (shows a prompt), + // 'silent' (does nothing) + // 'openBrowser' (opens the prototype URL in a browser window/tab) + // 'openPrview' (opens the codespaces preview window to present the running prototype to the user) + "onAutoForward": "openPreview" + } + }, + // forward the port for the browersync process + "forwardPorts": [3001], + "otherPortsAttributes": { "onAutoForward": "ignore" }, + // when created - sets the git merge statergy to rebase to hopefully make easier time of merging + "onCreateCommand": "git config --global pull.rebase true", + // after creation - installs the node packages + "postCreateCommand": "npm install", + // A command to run each time a tool has successfully attached to the container + "postAttachCommand": { + "server": "npm run watch" + }, + // codespace customisations + "customizations": { + // Configure properties specific to VS Code web-basde IDE used within codespaces. + "vscode": { + // editor settings + "settings": { + // uncomment the following lines to hide files not needed to update content + // "files.exclude": { + // "{docs,lib,linters,middleware,node_modules,public,tests,NHS111.Shared.Frontend}/": true, + // "*{CHANGELOG,CONTRIBUTING}.md": true, + // "app/{data,assets}/": true, + // "app/*.js": true, + // "*.{js,yml,json}": true, + // ".*": true, + // "LICENSE": true + // }, + // make emmet work within nunjucks + "emmet.includeLanguages": { + "njk": "html", + "nunjucks": "html", + "erb": "html", + "jinja": "html", + "jinja-html": "html", + "markdown": "html" + }, + "html.suggest.html5": true + }, + // bundle the following editor extensions + "extensions": [ + // nunjuck syntax highlighting + "douglaszaltron.nunjucks-vscode-extensionpack" + ] + } + } +} From 87054be10d67c1e643cea5cb869dbe3bcf3803db Mon Sep 17 00:00:00 2001 From: Paul Smith Date: Tue, 26 Nov 2024 10:16:06 +0000 Subject: [PATCH 2/3] Updates CHANGELOG.md with details of PR 428 --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1dbbe493..c513395b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,11 @@ - Changed all references from 'NHS.UK prototype kit' to 'NHS prototype kit' - Update default index page ([PR 423](https://github.com/nhsuk/nhsuk-prototype-kit/pull/423)) +### Added + +- Added a devcontainer.json file to configure Github Codespaces for use of the kit ([PR 428])(https://github.com/nhsuk/nhsuk-prototype-kit/pull/428)) + + ## 5.1.0 - 12 November 2024 - Remove guidance and tutorials - these can now be found online on the [NHS Prototype Kit website](https://prototype-kit.service-manual.nhs.uk) - ([PR 385](https://github.com/nhsuk/nhsuk-prototype-kit/pull/385)) From d11008696e814083a571b96257942a1df0130c9b Mon Sep 17 00:00:00 2001 From: Frankie Roberto Date: Tue, 10 Dec 2024 12:26:27 +0000 Subject: [PATCH 3/3] Fix changelog --- CHANGELOG.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c513395b..00087d36 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,9 +8,6 @@ - Update default service name ([PR 419](https://github.com/nhsuk/nhsuk-prototype-kit/pull/419)) - Changed all references from 'NHS.UK prototype kit' to 'NHS prototype kit' - Update default index page ([PR 423](https://github.com/nhsuk/nhsuk-prototype-kit/pull/423)) - -### Added - - Added a devcontainer.json file to configure Github Codespaces for use of the kit ([PR 428])(https://github.com/nhsuk/nhsuk-prototype-kit/pull/428))