Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some generated VIs use the grpcId.ctl from grpc-lvsupport.lvlib #287

Closed
pbirkhol-ni opened this issue Aug 9, 2023 · 5 comments · Fixed by #290 or #296
Closed

Some generated VIs use the grpcId.ctl from grpc-lvsupport.lvlib #287

pbirkhol-ni opened this issue Aug 9, 2023 · 5 comments · Fixed by #290 or #296
Labels
type: bug Something isn't working type: showstopper Issues that are blocking a client's release and need immediate attention.

Comments

@pbirkhol-ni
Copy link
Contributor

pbirkhol-ni commented Aug 9, 2023

MeasurementLink is trying to regenerate our grpc libraries using grpc-labview 1.0.0.6. The regeneration succeeds and the code works, but the server implementation has a dependency on grpcId.ctl from grpc-lvsupport.lvlib, which is distributed in the gRPC Server and Client Template VI package. This dependency should not be required for deployed code. Instead, all grpcId.ctl dependencies should come from grpc-lvsupport-release.lvlib.

This is easily reproducible using the helloworld.proto example. Simply generate a gRPC Server from that proto file and then open Get helloworld_HelloRequest.vi. You will see that one of the grpcId.ctl is from the wrong library.

image

AB#2483543

@pbirkhol-ni
Copy link
Contributor Author

FYI @Rohith-Grandhi, this is preventing MeasurementLink from upgrading. We would prefer a solution before the end of the cycle.

@Rohith-Grandhi Rohith-Grandhi added type: bug Something isn't working type: showstopper Issues that are blocking a client's release and need immediate attention. labels Aug 10, 2023
@pratheekshasn
Copy link
Collaborator

This issue has been fixed, and v1.0.0.6 has been re-released with the fix included. Please do download the binaries again, and uninstall the existing packages you have on your machine before you use the new binaries.

Please let us know if you face any other issues.

@pbirkhol-ni
Copy link
Contributor Author

I am reopening this bug since there are still some bad dependencies.

image

@pbirkhol-ni
Copy link
Contributor Author

I can't seem to reopen it. @pratheekshasn, can you fix the remaining issues?

@pratheekshasn pratheekshasn reopened this Aug 14, 2023
This was linked to pull requests Aug 22, 2023
@pratheekshasn
Copy link
Collaborator

I have submitted the fix for the issue in the following PRs:

#290
#296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: showstopper Issues that are blocking a client's release and need immediate attention.
Projects
None yet
3 participants