Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uptake new angular-eslint runtime-localize rule #153

Open
Tracked by #157
jattasNI opened this issue Aug 13, 2024 · 1 comment
Open
Tracked by #157

Uptake new angular-eslint runtime-localize rule #153

jattasNI opened this issue Aug 13, 2024 · 1 comment
Assignees

Comments

@jattasNI
Copy link
Collaborator

Describe the issue

@m-akinc added a new rule to angular-eslint in angular-eslint/angular-eslint#1898 which should help catch cases where strings are tagged with $localize in scopes that don't permit it, like file-level consts. This is now available in @angular-eslint/eslint-plugin. You can see the docs here.

We should enable this rule by default in our ruleset.

@jattasNI jattasNI changed the title Uptake new runtime-localize rule Uptake new angular-eslint runtime-localize rule Aug 13, 2024
@jattasNI jattasNI self-assigned this Sep 19, 2024
@jattasNI jattasNI removed the triage label Sep 19, 2024
@jattasNI
Copy link
Collaborator Author

I tried to fix this in the runtime-localize branch but hit snags.

  1. It requires installing @angular-eslint/eslint-plugin@18.3.0 but just bumping the version results in dependency conflicts with npm install
  2. I tried regenerating package-lock.json and that successfully installed the dependency but it seemed to break other rules. Our tests for @angular-eslint/template/i18n started failing claiming the content didn't have an i18n attribute even though it does.

I suspect both of these issues are because the angular-eslint version is supposed to align with the Angular version but we're on Angular 17. If this is true then this issue needs to wait on the Angular 18 upgrade.

@jattasNI jattasNI mentioned this issue Sep 19, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant