Update to actions/upload-artifact@v4 and actions/download-artifact@v4

[bkeryan]

Tech Debt

Starting with actions/upload-artifact@v4, GitHub artifacts are immutable and you cannot upload to the same artifact multiple times.

This repo's GitHub workflows currently use a single test_results artifact to combine results from multiple test jobs. To support actions/upload-artifact@v4, these workflows will need to be updated to use separate artifacts for each job. I don't know how to download a specific group of artifacts without knowing their names, but it looks like we can download all artifacts and then use the ones we care about.

See https://github.com/actions/toolkit/tree/main/packages/artifact for more info.

AB#2605029

AB#2783501

[bkeryan]

Before doing anything here, check actions/upload-artifact#472 for updated guidance on how to solve this.

[bkeryan]

Now there is a deprecation schedule: https://github.com/actions/upload-artifact

actions/upload-artifact@v3 is scheduled for deprecation on November 30, 2024. Learn more. Similarly, v1/v2 are scheduled for deprecation on June 30, 2024. Please update your workflow to use v4 of the artifact actions. This deprecation will not impact any existing versions of GitHub Enterprise Server being used by customers.

Also, now there are recommendations on how to update workflows that rely on merging outputs of multiple jobs into the same artifact: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md