Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zarr_extract_2d to help generate thumbnail images from OME-NGFF ZARR #62

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

blowekamp
Copy link
Collaborator

No description provided.

@blowekamp blowekamp requested a review from philipmac June 5, 2023 13:47
@blowekamp
Copy link
Collaborator Author

Current implementation is dependent on SimpleITK/SimpleITKUtilities#13

Copy link
Member

@philipmac philipmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible - separate target_size into explicit args, x and y, and default z to None.
If x or y are not provided -> error
ditch z.
If zarr array has z >1 -> error
x, y should be ints, defining numbers of pixels that are desired, this number is used to find the min size to find in array.

The new function can be used to generate thumbnails from OME-NGFF ZARR
structures.
Copy link
Member

@philipmac philipmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@blowekamp blowekamp marked this pull request as ready for review June 7, 2023 18:04
@blowekamp blowekamp changed the title WIP: initial prototype of zarr_extract function Add zarr_extract_2d to help generate thumbnail images from OME-NGFF ZARR Jun 7, 2023
@blowekamp blowekamp merged commit 3fd86f9 into niaid:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants