Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heaps.hs doesn't generate nice laws #36

Open
nick8325 opened this issue Feb 27, 2018 · 1 comment
Open

Heaps.hs doesn't generate nice laws #36

nick8325 opened this issue Feb 27, 2018 · 1 comment

Comments

@nick8325
Copy link
Owner

examples/Heaps.hs generated nicer laws in QS1.

The problem is partial functions. In QS1 we would get e.g. findMin h = head (toList h), but in QS2 since both terms are partial they are not considered equal.

I tried implementing the QS1 behaviour but since that is unsound many laws go missing.

We should probably discover findMin h = head (toList h) but in pruning, treat it as spoon (findMin h) = spoon (head (toList h)) or similar.
@MaximilianAlgehed
Copy link
Collaborator

Isn't treating terms as spoon t unsound in general (I seem to remember us having a discussion about this?) Have you got any specific condition in mind which could make it sound?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nick8325 @MaximilianAlgehed