Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate SocialSharing.methods.share to 3.0.0 #252

Closed
awronski opened this issue Nov 3, 2020 · 2 comments
Closed

Migrate SocialSharing.methods.share to 3.0.0 #252

awronski opened this issue Nov 3, 2020 · 2 comments

Comments

@awronski
Copy link

awronski commented Nov 3, 2020

Hi!

I use SocialSharing with nuxt.js. I call Google Analitics when sharing like this

plugins/social.js:

import Vue from 'vue'
import SocialSharing from 'vue-social-sharing'
import { gaLogSocial } from '~utils/GaUtils'

SocialSharing.methods.share = function (network) {

  gaLogSocial(network, this.url)

  this.openSharer(network, this.createSharingUrl(network))
  this.$root.$emit('social_shares_open', network, this.url)
}

Vue.use(SocialSharing)

But when migrating to new realease 3.0.3 it stoped working:
Cannot set property 'share' of undefined

How to migrate it?

Thanks,

@nicolasbeauvais
Copy link
Owner

Hello @awronski,

I do not have the time to work on Vue 3 compatibility yet. Please feel free to open a PR if you need this quickly.

Thank you.

@stale
Copy link

stale bot commented Jan 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 24, 2021
@stale stale bot closed this as completed Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants