Skip to content
This repository has been archived by the owner on Oct 11, 2020. It is now read-only.

Some characters not shown in ublock setting page on Win 10 insider build #98

Closed
lychichem opened this issue Dec 15, 2017 · 6 comments
Closed

Comments

@lychichem
Copy link

lychichem commented Dec 15, 2017

Read first: https://github.com/nikrolls/uBlock-Edge/blob/master/CONTRIBUTING.md

Describe the issue

After updated Windows 10 to the latest insider slow ring build (17025) and ublock to the latest version (1.14.22), characters in cloud storage setting panel and about panel cannot be shown.

One or more specific URLs where the issue occurs

The ublock internal page.
[URL(s) for issue on a specific site are mandatory]

Screenshot in which the issue can be seen

default
1

Steps for anyone to reproduce the issue

  1. Update Windows 10 to build 17025 (insider slow ring).
  2. Update ublock origin to 1.14.22
  3. Open ublock setting page and go to about panel or rule panel.

Your settings

[If you fail to provide this info, the issue will be marked as invalid. Lists all settings which differ from default]

  • OS/version: Window 10 insider preview build 17025 64-bit version, system language is Chinese Simplified.
  • Browser/version: Edge 41.17025.1000.0
  • uBlock Origin version: 1.14.22
Your filter lists

No filters

Your custom filters (if any)

https://raw.githubusercontent.com/523860169/list/master/ad.txt

Additional info:
This may related to MS released new version of MS YaHei, which is the default UI font for Chinese (Simplified). As a workaround, maybe we can force ublock use another font in setting page.

@kevin12314
Copy link

Cloud storage setting panel cannot be shown because cloud-ui.js line 93
time.toLocaleString('fullwide', timeOptions); Edge will get error with 'fullwide' parameter.
make-edge.sh in GitHub code tool folder has this code sed -i "s/'fullwide',\s*//g" $DES/js/*.js is to remove 'fullwide' parameter.
But I do not know why the release of this version has not been removed.

@lychichem
Copy link
Author

@kevin12314 so you mean it’s a js parsing error but not a font error?

@kevin12314
Copy link

@lychichem For cloud storage setting panel ,yes. Now @nikrolls has pushed an update and this new version has fixed this error.

@lychichem
Copy link
Author

@kevin12314 Okay I've seen ublock origin 1.14.23 fixed the issue partly as you mentioned. So what about the "about" panel? Does it also relates to js parsing error?

@kevin12314
Copy link

kevin12314 commented Dec 18, 2017

@lychichem I found that because about.html did not reference <script src="js/vapi.js"></script>. I found this code is in src but not in platform/edge. The released version will give priority to files under platform/edge. @nikrolls , Could you fix this issue in next version? Thank you.

@nicole-ashley
Copy link
Owner

@kevin12314 This is merged for the next release (working on it presently).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants