TargetParameterCountException when returning params in 2.5.1677

[rmja]

The following used to work:

using System;
using System.Threading.Tasks;
using Microsoft.VisualStudio.TestTools.UnitTesting;
using NiL.JS;
using NiL.JS.BaseLibrary;
using NiL.JS.Core;
using NiL.JS.Extensions;

namespace Tests.Fuzz
{
    [TestClass]
    public sealed class Bug_XXX
    {
        [TestMethod]
        public async Task ReturnParamsFromAsyncFunction()
        {
            var script = Script.Parse(
                @"
export default class Test {
    async run(params) {
        return params;
    }
}
"
            );
            var context = new GlobalContext();
            var module = new Module($"main.js", script, context);
            module.Run();

            var ctor = module.Exports.Default.As<Function>();
            var instance = ctor.Construct(new Arguments());
            var run = instance.GetProperty("run").As<Function>();

            var ints = new int[] { 1, 2, 3 };
            var result = await run.MakeDelegate<Func<int[], Task<JSValue>>>()(ints);

            Assert.AreEqual(6, result);
        }
    }
}

However, it now throws TargetParameterCountException. The regression is introduced in commit f2ea242

[nilproject]

I have not found any version where it was working. There was no implicit conversion from Promise to Task (but there is opposite conversion. Probably, it's a bug).
I have made some changes in Promise and some of them could have caused to some problems of types conversions. I guess, original code is more complex and may contain something helpful for investigation

[rmja]

Year, sorry. This example shows the regression:

using Microsoft.VisualStudio.TestTools.UnitTesting;
using NiL.JS;
using NiL.JS.BaseLibrary;
using NiL.JS.Core;
using NiL.JS.Extensions;
using System;
using System.Threading.Tasks;

namespace Tests.Fuzz
{
    [TestClass]
    public sealed class Bug_XXX
    {
        [TestMethod]
        public async Task ReturnParamsFromAsyncFunction()
        {
            var script = Script.Parse(
                @"
export default class Test {
    async run(params) {
        return params;
    }
}
"
            );
            var context = new GlobalContext();
            var module = new Module($"main.js", script, context);
            module.Run();

            var ctor = module.Exports.Default.As<Function>();
            var instance = ctor.Construct(new Arguments());
            var run = instance.GetProperty("run").As<Function>();

            var param = JSON.parse("{}");
            var result = run.MakeDelegate<Func<JSValue, JSValue>>()(param);
            if (result.Value is Promise promise)
            {
                result = await promise.Task;
            }

            Assert.AreEqual(param, result);
        }
    }
}

[rmja]

@nilproject Have you been able to trigger the regression with the above example?

[nilproject]

Yeah, thanks, i've fixed this