From ce8530cc5a9c2ba802329014de912b8525e45c1c Mon Sep 17 00:00:00 2001 From: hrxi Date: Fri, 3 May 2024 11:06:01 +0200 Subject: [PATCH] `protoc` isn't needed by `libp2p` anymore Hasn't been needed since libp2p 0.51.1. https://github.com/libp2p/rust-libp2p/pull/3312 --- .github/workflows/build+test.yml | 8 -------- .github/workflows/build_crate_features.yml | 2 -- .github/workflows/code_coverage.yml | 2 -- .github/workflows/devnet_release.yml | 2 -- .github/workflows/devnet_scenarios.yml | 2 -- .github/workflows/github_release_docker.yml | 3 --- .github/workflows/npm_publish.yml | 2 -- README.md | 1 - 8 files changed, 22 deletions(-) diff --git a/.github/workflows/build+test.yml b/.github/workflows/build+test.yml index da005bb876..c21bccbbf9 100644 --- a/.github/workflows/build+test.yml +++ b/.github/workflows/build+test.yml @@ -39,8 +39,6 @@ jobs: toolchain: stable components: llvm-tools-preview - uses: Swatinem/rust-cache@v2 - - name: Install Protoc - run: sudo apt-get install protobuf-compiler - name: Install cargo-nextest run: curl -LsSf https://get.nexte.st/latest/linux | tar zxf - -C ${CARGO_HOME:-~/.cargo}/bin # Coverage is disabled for now since at the moment it has a considerable performance impact in the CI @@ -80,8 +78,6 @@ jobs: toolchain: stable components: clippy - uses: Swatinem/rust-cache@v2 - - name: Install Protoc - run: sudo apt-get install protobuf-compiler - uses: actions-rs/clippy-check@v1 with: name: Clippy Report @@ -111,8 +107,6 @@ jobs: with: toolchain: stable - uses: Swatinem/rust-cache@v2 - - name: Install Protoc - run: sudo apt-get install protobuf-compiler - name: Install wasm-pack run: cargo install wasm-pack - name: Compile to wasm and generate bindings @@ -137,8 +131,6 @@ jobs: with: toolchain: stable - uses: Swatinem/rust-cache@v2 - - name: Install Protoc - run: sudo apt-get install protobuf-compiler - name: Build the code run: cargo build - name: Executes the 4 validators reconnecting scenario diff --git a/.github/workflows/build_crate_features.yml b/.github/workflows/build_crate_features.yml index 7554620374..04a9c595d1 100644 --- a/.github/workflows/build_crate_features.yml +++ b/.github/workflows/build_crate_features.yml @@ -16,8 +16,6 @@ jobs: with: toolchain: stable - uses: Swatinem/rust-cache@v2 - - name: Install Protoc - run: sudo apt-get install protobuf-compiler - name: Set up python uses: actions/setup-python@v5 with: diff --git a/.github/workflows/code_coverage.yml b/.github/workflows/code_coverage.yml index a41de59b5a..d52074a367 100644 --- a/.github/workflows/code_coverage.yml +++ b/.github/workflows/code_coverage.yml @@ -56,8 +56,6 @@ jobs: - uses: taiki-e/install-action@cargo-llvm-cov - uses: taiki-e/install-action@nextest - uses: Swatinem/rust-cache@v2 - - name: Install Protoc - run: sudo apt-get install protobuf-compiler - name: Remove possible stale artifacts run: cargo llvm-cov clean --workspace - name: Disk Space diff --git a/.github/workflows/devnet_release.yml b/.github/workflows/devnet_release.yml index f4ef03178c..acca75988c 100644 --- a/.github/workflows/devnet_release.yml +++ b/.github/workflows/devnet_release.yml @@ -65,8 +65,6 @@ jobs: - uses: Swatinem/rust-cache@v2 - name: Optionally patch the source run: ${{ matrix.pre }} - - name: Install Protoc - run: sudo apt-get install protobuf-compiler - name: Build the code run: cargo build --release - name: Retrieve initial timestamp diff --git a/.github/workflows/devnet_scenarios.yml b/.github/workflows/devnet_scenarios.yml index 5261327453..9d0d5861cd 100644 --- a/.github/workflows/devnet_scenarios.yml +++ b/.github/workflows/devnet_scenarios.yml @@ -58,8 +58,6 @@ jobs: - uses: Swatinem/rust-cache@v2 - name: Optionally patch the source run: ${{ matrix.pre }} - - name: Install Protoc - run: sudo apt-get install protobuf-compiler - name: Build the code run: cargo build - name: Retrieve initial timestamp diff --git a/.github/workflows/github_release_docker.yml b/.github/workflows/github_release_docker.yml index 56c8504bfe..be7d230472 100644 --- a/.github/workflows/github_release_docker.yml +++ b/.github/workflows/github_release_docker.yml @@ -11,9 +11,6 @@ jobs: runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v4 - - name: Install protoc - run: | - sudo apt-get update && sudo apt-get install -y protobuf-compiler - uses: actions-rs/toolchain@v1 with: toolchain: stable diff --git a/.github/workflows/npm_publish.yml b/.github/workflows/npm_publish.yml index 6c0a04a6a3..93f68cc556 100644 --- a/.github/workflows/npm_publish.yml +++ b/.github/workflows/npm_publish.yml @@ -17,8 +17,6 @@ jobs: toolchain: stable targets: wasm32-unknown-unknown - uses: Swatinem/rust-cache@v2 - - name: Install Protoc - run: sudo apt-get install protobuf-compiler - uses: jetli/wasm-bindgen-action@v0.2.0 with: version: 'latest' diff --git a/README.md b/README.md index 764a4bde12..d715c03533 100644 --- a/README.md +++ b/README.md @@ -56,7 +56,6 @@ the following packages are required to be able to compile the source code: - `cmake` - `libssl-dev` (in Debian/Ubuntu) or `openssl-devel` (in Fedora/Red Hat) - `pkg-config` -- `protobuf-compiler` After installing the previous packages, compiling the project is achieved through [`cargo`](https://doc.rust-lang.org/cargo/):