Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input not hidden #41

Open
0xAl3xH opened this issue Nov 4, 2017 · 0 comments
Open

Input not hidden #41

0xAl3xH opened this issue Nov 4, 2017 · 0 comments

Comments

@0xAl3xH
Copy link

0xAl3xH commented Nov 4, 2017

I installed react-star-rating from by running npm install react-star-rating -S and the current version as of the time of writing is 1.4.2 - it appears as "react-star-rating": "^1.4.2" in my package.json file. By having react datepicker in my code:

<StarRating name="react-star-rating" rating={3} totalStars={5}/>

The following is produced

screen shot 2017-11-04 at 7 03 25 pm

upon further digging, I found that there is a difference between the current source code and the code that is downloaded via npm and it is in line 324 of src/StarRating.jsx where the input type is number for the code downloaded via npm and hidden for the github code. Changing number to hidden and recompiling the code has gotten rid of this issue for me.

For those who are simply looking for a workaround, you could add the following css:

input[name="react-star-rating"] {
    display: none !important;
}

where name is whatever you named your StarRating component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant