Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Trying to read model parameter default from key <*>.csv seems slow #332

Open
willu47 opened this issue Mar 27, 2019 · 1 comment

Comments

@willu47
Copy link
Member

willu47 commented Mar 27, 2019

With the large number of parameters in the digital comms model, reading from multiple columns of a single default.csv file is very slow.

DEBUG    Trying to read model parameter default from key ../digital_comms/parameters/defaults.csv
DEBUG    Trying to read model parameter default from key ../digital_comms/parameters/defaults.csv
DEBUG    Trying to read model parameter default from key ../digital_comms/parameters/defaults.csv
DEBUG    Trying to read model parameter default from key ../digital_comms/parameters/defaults.csv
DEBUG    Trying to read model parameter default from key ../digital_comms/parameters/defaults.csv
DEBUG    Trying to read model parameter default from key ../digital_comms/parameters/defaults.csv
DEBUG    Trying to read model parameter default from key ../digital_comms/parameters/defaults.csv
DEBUG    Trying to read model parameter default from key ../digital_comms/parameters/defaults.csv
DEBUG    Trying to read model parameter default from key ../digital_comms/parameters/defaults.csv
DEBUG    Trying to read model parameter default from key ../digital_comms/parameters/defaults.csv
DEBUG    Trying to read model parameter default from key ../digital_comms/parameters/defaults.csv
DEBUG    Trying to read model parameter default from key ../digital_comms/parameters/defaults.csv
DEBUG    Trying to read model parameter default from key ../digital_comms/parameters/defaults.csv
DEBUG    Trying to read model parameter default from key ../digital_comms/parameters/defaults.csv
DEBUG    Trying to read model parameter default from key ../digital_comms/parameters/defaults.csv
DEBUG    Trying to read model parameter default from key ../digital_comms/parameters/defaults.csv```
@willu47
Copy link
Member Author

willu47 commented Mar 27, 2019

Could cache the csv file or call to store.read_parameter_file using functools.lru_cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant