Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warm start in combination with inter-timestep dependency fails to pick up outputs #401

Open
tomalrussell opened this issue Sep 16, 2019 · 0 comments
Labels

Comments

@tomalrussell
Copy link
Member

E.g. running nismod water_supply with warm start, ModelRun.run truncates the model horizon (timesteps) so the DataHandle created has no knowledge of the previous timesteps which were run previously.

These timesteps should not be re-run, but their outputs should be available through e.g. DataHandle.get_previous_timestep_data.

The fact that we do

self.model_horizon = self.model_horizon[idx:]

in ModelRun.run makes the logic in DataHandle._resolve_source invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant