Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use version from root/workspace for .output/package.json #1598

Closed
pi0 opened this issue Aug 17, 2023 · 2 comments · Fixed by #1607
Closed

Use version from root/workspace for .output/package.json #1598

pi0 opened this issue Aug 17, 2023 · 2 comments · Fixed by #1607
Labels
enhancement New feature or request

Comments

@pi0
Copy link
Member

pi0 commented Aug 17, 2023

Context: nuxt/nuxt#22678
@pi0 pi0 added the enhancement New feature or request label Aug 17, 2023
@pi0 pi0 mentioned this issue Aug 17, 2023
Closed
@luckilyhang
Copy link

Context: nuxt/nuxt#22678
Do you want to manually change the version in. ouput/server/package.json?
Shouldn't this be automatically generated by reading the version number of the root directory

@pi0
Copy link
Member Author

pi0 commented Aug 17, 2023

It is hardcoded to 0.0.0 at the moment:

https://github.com/unjs/nitro/blob/ce5d22340c26ae428f062d43f54d1b8aa7344ecd/src/rollup/plugins/externals.ts#L454

@pi0 pi0 mentioned this issue Aug 20, 2023
Merged
8 tasks
@pi0 pi0 closed this as completed in #1607 Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(externals): improved output package.json nitrojs/nitro
2 participants
@pi0 @luckilyhang