Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit with code (1) on build warnings #1619

Open
pi0 opened this issue Aug 22, 2023 · 0 comments
Open

exit with code (1) on build warnings #1619

pi0 opened this issue Aug 22, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@pi0
Copy link
Member

pi0 commented Aug 22, 2023

Build warnings (specially the ones related to externals) can cause the deployment to be failed (example: nitrojs/nitro-deploys#83) and this goes unnoticed during whole CI/CD and deploy pipeline.

I think it would be safer to fail CLI by code (1) by default with an explicit flag to opt-out. (this will be available for nitro CLI, framework integrations such as nuxi need to do it themselves and we need to somehow expose warnings information to them /cc @danielroe)

@pi0 pi0 added the enhancement New feature or request label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant