Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot build project in pnpm monorepo with externals disabled (cloudflare) #947

Closed
manniL opened this issue Feb 15, 2023 · 3 comments · Fixed by #948
Closed

cannot build project in pnpm monorepo with externals disabled (cloudflare) #947

manniL opened this issue Feb 15, 2023 · 3 comments · Fixed by #948
Labels
bug Something isn't working

Comments

@manniL
Copy link
Contributor

manniL commented Feb 15, 2023 •
edited
Loading

Environment

  • Operating System: Darwin
  • Node Version: v18.13.0
  • Nuxt Version: 0.0.0
  • Nitro Version: 2.2.1
  • Package Manager: pnpm@7.27.0
  • User Config: -
  • Runtime Modules: -
  • Build Modules: -

Reproduction

  1. Clone the repo
  2. pnpm i
  3. pnpm --filter app build
  4. See error in the console

Describe the bug

The build process throws an error saying:

Error: Cannot resolve "source-map-support/register.js" from "\u0000virtual:#internal/nitro/virtual/polyfill" and externals are not allowed!

Additional context

No response

Logs

No response
@manniL manniL added bug Something isn't working preset:cloudflare labels Feb 15, 2023
@pi0 pi0 changed the title PNPM monorepo + CF preset lead to error during build cannot build project in pnpm monorepo with externals disabled (cloudflare) Feb 15, 2023
@pi0
Copy link
Member

pi0 commented Feb 15, 2023

I can reproduce with noExternals: true for any preset. Seems search path is not working with pnpm/mono repo for rollup (but works with externals and nft)

@manniL
Copy link
Contributor Author

manniL commented Feb 15, 2023

Good catch, indeed!

@pi0 pi0 mentioned this issue Feb 15, 2023
Merged
7 tasks
@pi0 pi0 closed this as completed in #948 Feb 15, 2023
@manniL manniL mentioned this issue Feb 16, 2023
Closed
@eladcandroid
Copy link

Any news?
My build for NITRO_PRESET=vercel-edge isn't working and I see the same error about externals...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rollup): use mlly as fallback resolver when externals disabled nitrojs/nitro
3 participants
@manniL @pi0 @eladcandroid