Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haptic feedback only on touch-down event? #6

Open
chrisballinger opened this issue Jan 19, 2018 · 5 comments
Open

Haptic feedback only on touch-down event? #6

chrisballinger opened this issue Jan 19, 2018 · 5 comments
Assignees
Labels

Comments

@chrisballinger
Copy link

I'm curious if you've tried only doing the feedback on touch-down only, and not on touch-up.

If I touch the key fast enough I only seem to get the touch-down feedback, which makes the response feel inconsistent sometimes. Then I started wondering what it felt like if was possible to only send one haptic event instead of two.

@niw
Copy link
Owner

niw commented Jan 19, 2018

It is using both touch down and up and triggers different type of haptic feedbacks, as long as these two events are not happening in a very short period, which is 50ms now.
This is intentional implementation to address #3.

I think it’s reasonable behavior, however this is fixed value so we may want to adjust or make it configurable.

@niw niw self-assigned this Jan 19, 2018
@niw niw added the question label Jan 19, 2018
@munsuri
Copy link

munsuri commented Jan 23, 2018

For quick taps, personally, I find one key stroke (down) more natural with a better feeling. I have added three more cases to the app such as Down/Up key event (default), Down Key event or Up key event to keep experimenting.

@muescha
Copy link

muescha commented Jan 29, 2018

@munsuri can you create also a pull request for your changes?

@JMY1000
Copy link

JMY1000 commented Apr 22, 2018

It'd be nice to have this be configurable, as I'd prefer a much longer time. Asking the user to rebuild seems like kinda a hassle. I'd love to contribute, but Objective-C is unfortunately outside my wheelhouse for now.

@DennisSchiefer
Copy link

I played around with the kMinimumActuationInterval a bit and found that 200ms gives a pretty good experience for me personally.
Anything longer, I experience as a proper key press that should have down and up feedback.
Anything shorter, I experience as a tap, for which a single feedback is sufficient.

Also, major thumbs up to @niw for making this easy to compile (without any Ruby or XCode experience)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants