Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for linked projects #188

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

add support for linked projects #188

wants to merge 1 commit into from

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Jul 25, 2023

This allows having links between different packages within a monorepo.

TODO: add tests

@asmundo
Copy link

asmundo commented Nov 22, 2024

hi @zimbatm any plan for adding tests?

hi @andir any plan to accept this change?

If a test is what is needed to get this merged. I MAY BE able to get help from people with npm knowledge and create a test..

@andir
Copy link
Collaborator

andir commented Nov 26, 2024

I think one of my main issues is that I don't know what this does. Is it for local references within the same repository? If so, lets add a test and document it properly (within the test) so that the next person doesn't have to reverse engineer the test to understand it. This is already far from ideal in terms of mental complexity.

@asmundo
Copy link

asmundo commented Nov 27, 2024

I created the smallest example I could come up with IIUC. I failed to integrate in to the testing. My nix is only so good. If you have some hints on how to create the nix part it would be appropriated! Happy to do it but it may take some times. If you just feel like doing that part yourself I am fine with that. A rewrite of testing framework to support this is outside of my Nix knowledge.

local-dependency.tar.gz

@asmundo
Copy link

asmundo commented Nov 27, 2024

Could be there is a test I can copy and modify with limited knowledge, is there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants