Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project branches #1839

Closed
walnutfalls opened this issue Nov 13, 2019 · 5 comments
Closed

Project branches #1839

walnutfalls opened this issue Nov 13, 2019 · 5 comments
Labels
kind: question solution: proposed fix a fix for the issue has been proposed and waits for confirmation

Comments

@walnutfalls
Copy link

walnutfalls commented Nov 13, 2019 •
edited
Loading

I'm trying to point CMake's ExternalProject_Add to set up a dependency on this library.

I put release/3.70 as git tag, but this branch was removed. This breaks my build. Should release branches/tags ever be removed? Am I better off just pointing at master?
@t-b
Copy link
Contributor

t-b commented Nov 13, 2019

@concubicycle You probably have referenced a branch or? The tags are listed at https://github.com/nlohmann/json/tags.

@walnutfalls
Copy link
Author

Ah, yep! I put release/3.7.0. v3.7.2 is probably what I want.

@nlohmann
Copy link
Owner

Indeed you should use tags.

@nlohmann
Copy link
Owner

@concubicycle Do you need further assistance with this issue?

@nlohmann nlohmann added the solution: proposed fix a fix for the issue has been proposed and waits for confirmation label Nov 14, 2019
@walnutfalls
Copy link
Author

No, thank you guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: question solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nlohmann @t-b @walnutfalls