Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++20: char8_t #2097

Closed
igoloe opened this issue May 9, 2020 · 4 comments
Closed

C++20: char8_t #2097

igoloe opened this issue May 9, 2020 · 4 comments
Labels
kind: enhancement/improvement

Comments

@igoloe
Copy link

igoloe commented May 9, 2020

Are there any plans to move to std::u8string once char8_t literals are default for u8? Or should this be adressed by clients defining the string_type as std::u8string?
@nlohmann
Copy link
Owner

nlohmann commented May 9, 2020

This library targets C++11, so we cannot default to char8_t. I'm afraid the clients need to do that, but I have not tested this yet.

@igoloe
Copy link
Author

igoloe commented May 9, 2020

Ok. I will report about our experience. Thx.

@igoloe igoloe closed this as completed May 9, 2020
@nlohmann
Copy link
Owner

nlohmann commented May 9, 2020

That would be great!

@shrinktofit
Copy link

Watch on this! std::u8string_view is serialized as number array now.. I have to explicitly convert it into std::string_view every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: enhancement/improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nlohmann @shrinktofit @igoloe