Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conan.io #566

Closed
Pancir opened this issue Apr 20, 2017 · 17 comments
Closed

Conan.io #566

Pancir opened this issue Apr 20, 2017 · 17 comments

Comments

@Pancir
Copy link

Pancir commented Apr 20, 2017

Hello guys I think it would be a good idea to make the library to be available through the conan. https://www.conan.io/
I could do it without your help but it is the better way when the developers is responsible for it themselves.

@nlohmann
Copy link
Owner

I think it's already there: https://www.conan.io/source/nlJson/2.0.2/arnemertz/stable

That version is outdated. Would it make sense to add another one?

@Pancir
Copy link
Author

Pancir commented Apr 20, 2017

Anyone can add to the conan's repository any library, but official supporting is always better. For example it could be uploaded from the CI at once and the conan's recipe could be adjusted properly by the developers and it could have correct naming and user in the canan's repository.
Anyway it is just a suggestion to adjust delivering to the conan's repository.

@nlohmann
Copy link
Owner

nlohmann commented Jun 7, 2017

@Pancir What exactly needs to be done for this? Is it sufficient to create a conanfile.py like this: https://github.com/arnemertz/conan-nlJson/blob/master/conanfile.py ?

@Pancir
Copy link
Author

Pancir commented Jun 7, 2017

Yes and usually you have to create the test_package for checking the recipe.
BTW The conanfile.py with the test_package can be in separated repository if you wish, you can see it with the link you have specified, it is in another repository.
The test_package is just a simple consumer.
http://conanio.readthedocs.io/en/latest/reference/commands/test_package.html
http://conanio.readthedocs.io/en/latest/packaging/getting_started.html#the-test-package-folder

@nlohmann
Copy link
Owner

nlohmann commented Jun 8, 2017

I just learned conan.io is deprecated.

@Pancir
Copy link
Author

Pancir commented Jun 8, 2017

Yes, they just moved their public repository to another place. I don't learn the issue about this moving yet but I guess it should not affect the conanfile.py and the test_package.
The conan is still young and it is under active developing.

@nlohmann
Copy link
Owner

nlohmann commented Jun 8, 2017

I am currently not planning to invest time into this. A PR would be appreciated.

@Pancir
Copy link
Author

Pancir commented Jun 8, 2017

Sorry, I don't know what "PR" means.

@nlohmann
Copy link
Owner

nlohmann commented Jun 8, 2017

A pull request. If anyone would create the required files (such as https://github.com/nlohmann/json/blob/develop/meson.build for Meson, see #576), I would be happy to add them to my repository.

@Pancir
Copy link
Author

Pancir commented Jun 8, 2017

Thx for the explanation.

@nlohmann nlohmann added solution: proposed fix a fix for the issue has been proposed and waits for confirmation and removed solution: proposed fix a fix for the issue has been proposed and waits for confirmation labels Jun 16, 2017
@nlohmann
Copy link
Owner

@Pancir As I described in #619, I cannot maintain Conan.io myself. If someone (like @arnemertz before) can maintain a repository with the required files, I would be happy.

@nlohmann nlohmann added the state: help needed the issue needs help to proceed label Jun 16, 2017
@nlohmann
Copy link
Owner

I shall leave this ticket open for a while.

@vthiery
Copy link

vthiery commented Jun 17, 2017

As discussed, I packaged the library (version 2.1.1) here conan-jsonformoderncpp and made it available on Bintray.

@nlohmann
Copy link
Owner

Great. What should I add to the README (about 1 sentence) so that Conan users would know what to do?

@vthiery
Copy link

vthiery commented Jun 17, 2017

In the same spirit of what I proposed in #619 , I would suggest:

If you are using Conan to manage your dependencies, merely add jsonformoderncpp/x.y.z@vthiery/stable to your conanfile.py's requires, where x.y.z is the release version you want to use. Please file issues here if you experience problems with the packages.

@nlohmann
Copy link
Owner

Thanks a lot! I shall update the README accordingly.

nlohmann added a commit that referenced this issue Jun 17, 2017
@nlohmann nlohmann removed the state: help needed the issue needs help to proceed label Jun 17, 2017
@nlohmann nlohmann self-assigned this Jun 17, 2017
@nlohmann nlohmann added this to the Release 3.0.0 milestone Jun 17, 2017
@Pancir
Copy link
Author

Pancir commented Jun 17, 2017

Thank you guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants