Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json_fwd.hpp not installed #923

Closed
zerodefect opened this issue Jan 18, 2018 · 4 comments
Closed

json_fwd.hpp not installed #923

zerodefect opened this issue Jan 18, 2018 · 4 comments

Comments

@zerodefect
Copy link
Contributor

Bug Report

  • What is the issue you have?

Not sure if this is by design or not, but I notice that when I perform 'cmake install', the json_fwd.hpp is not installed.

  • What is the expected behavior?

Well, if I want to perform an in-source build (ExternalProject_Add()), as an example, it makes things difficult if their is no install procedure for the fwd declaration.

Ubuntu 17.10 and GCC v7.2

  • Did you use a released version of the library or the version from the develop branch?

Released

@theodelrieu
Copy link
Contributor

The default install method only installs the amalgamated json.hpp, you have to set the CMake option -DJSON_MultipleHeaders=ON.

@gregmarr
Copy link
Contributor

I think installing the fwd header in the default install would make sense. Lots of people want forward declarations but don't need the rest of the individual headers.

@zerodefect
Copy link
Contributor Author

@gregmarr I agree actually. Nonetheless, I feel that is a separate issue (imho).

@theodelrieu
Copy link
Contributor

I personally want to include only adl_serializer.hpp in my code, for this I need every header installed.

That's why I think adding another target to install the amalgamated version + json_fwd is superfluous.

Users can still only include json.hpp as before, I'm not sure having every header or not is a big issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants