Fix memory leak during parser callback #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part 1: properly use forwarding
theodelrieu
reviewed
Mar 9, 2018
| @@ -953,7 +953,7 @@ class basic_json | |||
| /// constructor for rvalue strings | |||
| json_value(string_t&& value) | |||
| { | |||
| string = create<string_t>(std::move(value)); | |||
| string = create<string_t>(std::forward < string_t&& > (value)); | |||
There was a problem hiding this comment.
std::move was correct here (and in all the other places in this PR) since value is not a forwarding reference, but an rvalue reference.
The behaviour is the same in this case, but is quite confusing.
|
Thanks, I’ll change that. I was totally confused that the memory leak went undetected for so long. |
nlohmann
added a commit
that referenced
this pull request
Mar 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak in the case when the parser callback function discards values. The reason was a forgotten destroy call.
Thanks to @RalfBielig for reporting and proposing a fix.