Fixes https://github.com/nlohmann/json/issues/1387 #1389
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.]
In #1387, a user was facing difficulty because he was using map class.
Map class sorts it's elements on the basis of
< function
by default.Now this meant that the bug existed in inline bool operator< defined at value_t.hpp
If you are to look at the Numerics Mentioned beside the comment in the previous code base, you would find that they do not match the one mentioned/implied in enum class value_t
The correction of these values fixes the issue altogether
Further I carried out a small modification to the .gitignore file so that it starts ignoring Visual Studio IDE auto-generated files( which I used).
Should I delete the .gitignore modification?
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmann
directory, runmake amalgamate
to create the single-header filesingle_include/nlohmann/json.hpp
. The whole process is described here.Please don't
#ifdef
s or other means.