Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill two warnings #140

Closed
wants to merge 1 commit into from
Closed

kill two warnings #140

wants to merge 1 commit into from

Conversation

406345
Copy link

@406345 406345 commented Oct 22, 2015

sprintf(&result[pos + 1], "u%04x", int(c)); ----> sprintf_s(&result[pos + 1],result.size(),"u%04x", int(c));

difference_type m_it = std::numeric_limitsstd::ptrdiff_t::min(); ----> difference_type m_it = std::numeric_limitsstd::ptrdiff_t::denorm_min();

@benloong
Copy link

sprintf_s is not cross platform, you may use snprintf(since c++11) instead.

@nlohmann
Copy link
Owner

nlohmann commented Dec 7, 2015

Thanks for the CR! After #153, sprintfis not called any more. I shall commit the change to using denorm_min separately.

@nlohmann
Copy link
Owner

nlohmann commented Dec 7, 2015

@406345, just out of curiosity, which tool gave you a warning about denorm_min()?

nlohmann added a commit that referenced this pull request Dec 7, 2015
@nlohmann nlohmann closed this Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants