Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gcc9 build error test/src/unit-allocator.cpp (Issue #1472) #1492

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Fix gcc9 build error test/src/unit-allocator.cpp (Issue #1472) #1492

merged 1 commit into from
Mar 11, 2019

Conversation

stac47
Copy link
Contributor

@stac47 stac47 commented Feb 22, 2019

Hello,
This fix the compilation of test/src/unit-allocator.cpp as described in issue #1472.

I validated the compilation + tests on:

  • gcc (GCC) 9.0.1 20190205 (experimental)
  • gcc (GCC) 8.2.1 20190205
  • gcc (GCC) 6.5.0

Congrats to @theodelrieu for this nice catch.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ddc9f20 on stac47:fix_gcc9_allocator into 21516f2 on nlohmann:develop.

nlohmann
nlohmann approved these changes Mar 11, 2019
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Mar 11, 2019
@nlohmann nlohmann added this to the Release 3.6.0 milestone Mar 11, 2019
@nlohmann
Copy link
Owner

Merging even though Travis failed. The failing CI step is deprecated and removed in develop branch.

@nlohmann nlohmann merged commit cabe235 into nlohmann:develop Mar 11, 2019
@nlohmann
Copy link
Owner

Thanks!

@nlohmann nlohmann mentioned this pull request Mar 11, 2019
Closed
@nlohmann nlohmann mentioned this pull request Mar 21, 2019
Closed
@hightower8083 hightower8083 mentioned this pull request Aug 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🐛 bug fix
Projects
None yet
Milestone
Release 3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@stac47 @coveralls @nlohmann