appveyor.yml: Add MSVC 16 2019 support #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We would appreciate it if you could provide us with more info about this issue or pull request! Please check the issue template and the pull request template. |
request-info
bot
added
the
state: needs more info
nlohmann
requested changes
Oct 9, 2019
There was a problem hiding this comment.
Could you please check why the AppVeyor builds are failing: https://ci.appveyor.com/project/nlohmann/json/builds/27941353?
t-b
force-pushed
the
add-msvc-16-2019
branch
4 times, most recently
from
e3ce966 to
2391a04
Compare
This was referenced Oct 15, 2019
t-b
force-pushed
the
add-msvc-16-2019
branch
2 times, most recently
from
b05e49d to
f77841e
Compare
In a future commit we want to add support for MSVC 2019. For that version cmake requires us to pass in the architecture not part of the generator but explicitly. So let's pass that in always like that. This also removes the doubling of the platform/architecture.
|
@nlohmann Ready |
|
@nlohmann Anything still missing here? |
nlohmann
approved these changes
Nov 2, 2019
nlohmann
added
platform: visual studio
|
Thanks! |
🔖 Release itemThis issue/PR will be part of the next release of the library. This template helps preparing the release notes. Type
Description
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
silence bot!