Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #185 - remove approx() and use #pragma to kill warnings #190

Merged
merged 2 commits into from
Jan 24, 2016

Conversation

twelsby
Copy link
Contributor

@twelsby twelsby commented Jan 23, 2016

Removed the use of approx as discussed in issue #185. Understandably this will cause angst for some but as I stated in the issue it isn't doing what it is designed for and what it is designed for shouldn't be done. I look forward to comments on the issue and have no issues continuing with the current way of doing things if any concerns cannot be placated.

@twelsby twelsby mentioned this pull request Jan 23, 2016
nlohmann added a commit that referenced this pull request Jan 24, 2016
fixed #185 - remove approx() and use #pragma to kill warnings
@nlohmann nlohmann merged commit e00b00f into nlohmann:master Jan 24, 2016
@nlohmann nlohmann added this to the Release 1.0.1 milestone Jan 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants