Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link to parse function in README #1918

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Fix link to parse function in README #1918

merged 1 commit into from
Jan 31, 2020

Conversation

kastiglione
Copy link
Contributor

This corrects the link to parse in the README.

@kastiglione
Copy link
Contributor Author

I'm not sure how often those link slugs change.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f25a128 on kastiglione:patch-1 into 6ca5338 on nlohmann:develop.

nlohmann
nlohmann approved these changes Jan 31, 2020
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Jan 31, 2020
@nlohmann nlohmann added this to the Release 3.7.4 milestone Jan 31, 2020
@nlohmann nlohmann merged commit 3eb6b0e into nlohmann:develop Jan 31, 2020
@nlohmann
Copy link
Owner

Thanks!

@nlohmann
Copy link
Owner

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description

@kastiglione kastiglione deleted the patch-1 branch January 31, 2020 22:32
@kastiglione
Copy link
Contributor Author

@nlohmann thanks for the library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
documentation release item: 🔨 further change
Projects
None yet
Milestone
Release 3.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kastiglione @coveralls @nlohmann @f3rm4rf3r