Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to not rely on Internet connectivity during test stage #2202

Merged
merged 5 commits into from
Jun 21, 2020
Merged

Add option to not rely on Internet connectivity during test stage #2202

merged 5 commits into from
Jun 21, 2020

Conversation

nlohmann
Copy link
Owner

This PR fixes two issues that were introduced in #2081:

  • Adds a parameter JSON_TestDataDirectory to pass a directory of test files to avoid checking them out during ctest stage.
  • Adds label git_required to tests that require a Git checkout and would fail if library is downloaded other than via Git.
  • Add documentation to the test section of the README file.

Closes #2189

@nlohmann nlohmann self-assigned this Jun 20, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2499200 on issue2189 into 74c6e42 on develop.

@nlohmann nlohmann mentioned this pull request Jun 20, 2020
Closed
5 tasks
@nlohmann nlohmann added this to the Release 3.8.1 milestone Jun 21, 2020
@nlohmann nlohmann merged commit 8dade80 into develop Jun 21, 2020
@nlohmann nlohmann deleted the issue2189 branch June 21, 2020 06:41
@nlohmann
Copy link
Owner Author

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description

@nlohmann nlohmann mentioned this pull request Jun 21, 2020
Closed
5 tasks
bob-beck pushed a commit to openbsd/ports that referenced this pull request Dec 28, 2023
@klemensn
Fix tests
fd8037b 
The "only 4 tests that try to git clone fail" comment is wrong, most of the
91 tests fail fetching data;  nlohmann/json#2202
from 2020 added an option to use prefetched test data and skip git usage,
so do that and have 87/87 tests pass (on amd64).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.9.0
Development

Successfully merging this pull request may close these issues.

3.8.0: unit-cbor.cpp test failures
2 participants
@nlohmann @coveralls